[PATCH v2 08/18] libcamera: software_isp: Add SwStatsCpu class

[Hans de Goede]

Hi,

On 1/23/24 22:55, Laurent Pinchart wrote:
> On Tue, Jan 23, 2024 at 09:04:18PM +0100, Milan Zamazal wrote:
>> Hans de Goede <hdegoede at redhat.com> writes:

<sni>

>>> +void SwStatsCpu::statsBGGR10PLine0(const uint8_t *src[])
> 
> This should take a std::array<const uint8_t *, 3>.

That won't work since the same function pointer is also used
for Bayer patterns which repeat every 4 lines and in that
case 5 src line pointers are passed.

>>> +void SwStatsCpu::resetStats(void)
>>> +{
>>> +	stats_.sumR_ = 0;
>>> +	stats_.sumB_ = 0;
>>> +	stats_.sumG_ = 0;
>>> +	std::fill_n(stats_.y_histogram, 16, 0);
>>
>> Another use of the y_histogram size constant.
> 
> You could make the histogram a std::array<unsigned int, 16>.

Ack, fixed.

Regards,

Hans