[PATCH v3 00/16] libcamera: introduce Software ISP and Software IPA

Hans de Goede hdegoede at redhat.com
Wed Feb 14 18:26:32 CET 2024


Hi,

On 2/14/24 18:03, Hans de Goede wrote:
> Hi All,
> 
> On 2/14/24 18:01, Hans de Goede wrote:
>> Hi All,
>>
>> Here is v3 of the patch-set to add Software ISP support
>> to libcamera / to the simple pipeline-handler.
> 
> Note as Kieran pointed out in an offlist email, the new CI has
> already caught a couple of issues with this v3:
> 
> Unit test configuration failed to build:
>  - https://gitlab.freedesktop.org/camera/libcamera-softisp/-/jobs/55028866#L357

Ok, so I took a quick peek at this one and the issue is
that the simple pipeline handler will not build unless
-Dipas=simple is passed when configuring.

The missing header here is autogenerated.

I see that the ipu3 pipeline handler also unconditionally
includes the auto-generated:

#include <libcamera/ipa/ipu3_ipa_interface.h>
#include <libcamera/ipa/ipu3_ipa_proxy.h>

headers, so it will show similar erros when using -Dpipelines=ipu3
without -Dipas=ipu3 .

So I wonder how to fix this. Is there some meson magic
somewhere to automatically enable the ipu3 ipa when the
ipu3 pipeline is enabled which we can copy for the simple
pipeline ?

Regards,

Hans







More information about the libcamera-devel mailing list