[PATCH v3 3/5] ipa: rkisp1: Fix histogram weights configuration

[Stefan Klug]

Am 18.02.24 um 17:49 schrieb Laurent Pinchart:
> The histogram weights are initialized to hardcoded 1's for each
> histogram grid cell. The code uses the wrong variable for the grid size,
> resulting in some weights having a 0 value. Fix it.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Stefan Klug <stefan.klug at ideasonboard.com>

> ---
>   src/ipa/rkisp1/algorithms/agc.cpp | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp
> index da705b14754c..47a6f7b26744 100644
> --- a/src/ipa/rkisp1/algorithms/agc.cpp
> +++ b/src/ipa/rkisp1/algorithms/agc.cpp
> @@ -175,7 +175,7 @@ void Agc::prepare(IPAContext &context, const uint32_t frame,
>   	/* Set an average weighted histogram. */
>   	Span<uint8_t> weights{
>   		params->meas.hst_config.hist_weight,
> -		context.hw->numHistogramBins
> +		context.hw->numHistogramWeights
>   	};
>   	std::fill(weights.begin(), weights.end(), 1);
>   	/* Step size can't be less than 3. */

-- 
Regards,

Stefan Klug