[PATCH v3 4/5] include: linux: Add RKISP1_V_IMX8MP version

[Stefan Klug]

Am 18.02.24 um 17:49 schrieb Laurent Pinchart:
> From: Paul Elder <paul.elder at ideasonboard.com>
> 
> Patches have been posted to the linux-media at vger.kernel.org mailing list
> to add i.MX8MP support to the rkisp1 driver ([1]). As no changes are
> expected to the userspace API in future versions of the series, add the
> RKISP1_V_IMX8MP version manually to the rkisp1-config.h header already.
> Once the patches get merged in the kernel, the changes will trickle down
> to libcamera with the next kernel headers update.
> 
> [1] https://lore.kernel.org/linux-media/20240216095458.2919694-1-paul.elder@ideasonboard.com/
> 
> Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Stefan Klug <stefan.klug at ideasonboard.com>

> ---
>   include/linux/rkisp1-config.h | 8 +++++---
>   1 file changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/include/linux/rkisp1-config.h b/include/linux/rkisp1-config.h
> index ec7cde8cd2e3..2d1c448a6ab8 100644
> --- a/include/linux/rkisp1-config.h
> +++ b/include/linux/rkisp1-config.h
> @@ -4,8 +4,8 @@
>    * Copyright (C) 2017 Rockchip Electronics Co., Ltd.
>    */
>   
> -#ifndef _RKISP1_CONFIG_H
> -#define _RKISP1_CONFIG_H
> +#ifndef _UAPI_RKISP1_CONFIG_H
> +#define _UAPI_RKISP1_CONFIG_H
>   
>   #include <linux/types.h>
>   
> @@ -179,12 +179,14 @@
>    * @RKISP1_V11: declared in the original vendor code, but not used
>    * @RKISP1_V12: used at least in rk3326 and px30
>    * @RKISP1_V13: used at least in rk1808
> + * @RKISP1_V_IMX8MP: used in at least imx8mp
>    */
>   enum rkisp1_cif_isp_version {
>   	RKISP1_V10 = 10,
>   	RKISP1_V11,
>   	RKISP1_V12,
>   	RKISP1_V13,
> +	RKISP1_V_IMX8MP,

IMHO it might be more flexible in the future to start with a new number. 
eg. RKISP1_V_IMX8MP = 100

>   };
>   
>   enum rkisp1_cif_isp_histogram_mode {
> @@ -992,4 +994,4 @@ struct rkisp1_stat_buffer {
>   	struct rkisp1_cif_isp_stat params;
>   };
>   
> -#endif /* _RKISP1_CONFIG_H */
> +#endif /* _UAPI_RKISP1_CONFIG_H */

-- 
Regards,

Stefan Klug