[PATCH 1/3] ipa: libipa: Allow retrieving the name of a CameraSensorHelperFactory

Kieran Bingham kieran.bingham at ideasonboard.com
Fri Feb 23 16:59:52 CET 2024


Support the test suite iterating the factories by exposing a const
retriever of the factory name.

---
An alternative here is to just allow direct access to the
createInstance() from the test too, without having to re-search
all of the factories each time. But I felt this was less
of a de-restriction of the existing interfaces.

Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
---
 src/ipa/libipa/camera_sensor_helper.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/ipa/libipa/camera_sensor_helper.h b/src/ipa/libipa/camera_sensor_helper.h
index 3ea1806cb1fd..dcdbe82b7ac9 100644
--- a/src/ipa/libipa/camera_sensor_helper.h
+++ b/src/ipa/libipa/camera_sensor_helper.h
@@ -68,6 +68,8 @@ public:
 
 	static std::vector<CameraSensorHelperFactoryBase *> &factories();
 
+	const std::string &name() const { return name_; };
+
 private:
 	LIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactoryBase)
 
-- 
2.34.1



More information about the libcamera-devel mailing list