[PATCH] android: camera_device: The first valid settings should be saved

Jacopo Mondi jacopo.mondi at ideasonboard.com
Mon Feb 26 15:21:49 CET 2024


Also,
  as there's a bug assigned to this issue

On Mon, Feb 26, 2024 at 11:08:12AM +0800, Fang Hui wrote:
> If not, it will be deferred to the next frame.
>

Bug: https://bugs.libcamera.org/show_bug.cgi?id=210

> Signed-off-by: Fang Hui <hui.fang at nxp.com>
> ---
>  src/android/camera_device.cpp | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
> index 25cedd44..d45ed1a5 100644
> --- a/src/android/camera_device.cpp
> +++ b/src/android/camera_device.cpp
> @@ -952,8 +952,8 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques
>  	 */
>  	if (camera3Request->settings)
>  		lastSettings_ = camera3Request->settings;
> -	else
> -		descriptor->settings_ = lastSettings_;
> +
> +	descriptor->settings_ = lastSettings_;
>
>  	LOG(HAL, Debug) << "Queueing request " << descriptor->request_->cookie()
>  			<< " with " << descriptor->buffers_.size() << " streams";
> --
> 2.25.1
>


More information about the libcamera-devel mailing list