[PATCH] android: camera_device: Save capture settings unconditionally

Fang Hui hui.fang at nxp.com
Tue Feb 27 03:13:20 CET 2024


If not, it will be deferred to the next frame,
as there's a bug assigned to this issue
https://bugs.libcamera.org/show_bug.cgi?id=210

Signed-off-by: Fang Hui <hui.fang at nxp.com>
---
 src/android/camera_device.cpp | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp
index 25cedd44..d45ed1a5 100644
--- a/src/android/camera_device.cpp
+++ b/src/android/camera_device.cpp
@@ -952,8 +952,8 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques
 	 */
 	if (camera3Request->settings)
 		lastSettings_ = camera3Request->settings;
-	else
-		descriptor->settings_ = lastSettings_;
+
+	descriptor->settings_ = lastSettings_;
 
 	LOG(HAL, Debug) << "Queueing request " << descriptor->request_->cookie()
 			<< " with " << descriptor->buffers_.size() << " streams";
-- 
2.25.1



More information about the libcamera-devel mailing list