[PATCH 2/2] utils: checkstyle.py: Update LogCategoryChecker regexp

Laurent Pinchart laurent.pinchart at ideasonboard.com
Tue Feb 27 13:29:43 CET 2024


Hi Milan,

Thank you for the patch.

On Tue, Feb 27, 2024 at 01:14:47PM +0100, Milan Zamazal wrote:
> The regexp uses obsolete form, update it to mute the warning emitted by Python
> 3.12:
> 
>   SyntaxWarning: invalid escape sequence '\('
> 
> Signed-off-by: Milan Zamazal <mzamazal at redhat.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  utils/checkstyle.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/utils/checkstyle.py b/utils/checkstyle.py
> index af553cfd..fb03dc34 100755
> --- a/utils/checkstyle.py
> +++ b/utils/checkstyle.py
> @@ -588,7 +588,7 @@ class IncludeChecker(StyleChecker):
>  
>  
>  class LogCategoryChecker(StyleChecker):
> -    log_regex = re.compile('\\bLOG\((Debug|Info|Warning|Error|Fatal)\)')
> +    log_regex = re.compile(r'\bLOG\((Debug|Info|Warning|Error|Fatal)\)')
>      patterns = ('*.cpp',)
>  
>      def __init__(self, content):

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list