[libcamera-devel] [PATCH] lc-compliance: Set minimum version for gtest dependency

[Jacopo Mondi]

Hi Laurent

On Tue, Jan 09, 2024 at 04:30:31PM +0200, Laurent Pinchart wrote:
> lc-compliance depends on support for skipping tests in gtest (commit
> 00938b2b228f upstream, merged in v1.10.0). Set the corresponding minimum
> version for the gtest dependency.

V1.10 has been released in Oct 3, 2019.

As a reference V1.10 is part of Ubuntu 20.04 and is available for
buster (oldstable) in backports.

I guess we're safe then ?
Reviewed-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
>  src/apps/lc-compliance/meson.build | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/src/apps/lc-compliance/meson.build b/src/apps/lc-compliance/meson.build
> index dd7b73abbcef..c2afc09ffb6c 100644
> --- a/src/apps/lc-compliance/meson.build
> +++ b/src/apps/lc-compliance/meson.build
> @@ -1,6 +1,7 @@
>  # SPDX-License-Identifier: CC0-1.0
>
> -libgtest = dependency('gtest', required : get_option('lc-compliance'),
> +libgtest = dependency('gtest', version : '>=1.10.0',
> +                      required : get_option('lc-compliance'),
>                        fallback : ['gtest', 'gtest_dep'])
>
>  if opt_lc_compliance.disabled() or not libevent.found() or not libgtest.found()
> --
> Regards,
>
> Laurent Pinchart
>