[libcamera-devel] [PATCH] libipa: camera_sensor_helper: Mark createInstance() with override

[Kieran Bingham]

Quoting Laurent Pinchart via libcamera-devel (2024-01-12 10:02:03)
> The CameraSensorHelperFactory::createInstance() function overrides a
> virtual function from CameraSensorHelperFactoryBase. The function
> declaration doesn't mark it with the override keyword. This could cause
> issues in the future if the base class' function changes, as the
> compiler will not issue any warning in that case. Fix it.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> ---
>  src/ipa/libipa/camera_sensor_helper.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/ipa/libipa/camera_sensor_helper.h b/src/ipa/libipa/camera_sensor_helper.h
> index 3ea1806cb1fd..1ca9371be6ff 100644
> --- a/src/ipa/libipa/camera_sensor_helper.h
> +++ b/src/ipa/libipa/camera_sensor_helper.h
> @@ -88,7 +88,7 @@ public:
>         }
>  
>  private:
> -       std::unique_ptr<CameraSensorHelper> createInstance() const
> +       std::unique_ptr<CameraSensorHelper> createInstance() const override
>         {
>                 return std::make_unique<_Helper>();
>         }
> 
> base-commit: 89227a428a82e724548399d35c98ea89566f9045
> -- 
> Regards,
> 
> Laurent Pinchart
>