[libcamera-devel] [PATCH v2 15/18] libcamera: pipeline: simple: enable use of Soft ISP and Soft IPA

[Pavel Machek]

Hi!

>  
> +	/*
> +	 * Create SoftwareIsp unconditionally if no converter is used
> +	 * - to be revisited
> +	 */
> +	if (!converter_) {
> +		swIsp_ = SoftwareIspFactoryBase::create(pipe, sensor_->controls());
> +		if (!swIsp_) {
> +			LOG(SimplePipeline, Warning)
> +				<< "Failed to create software ISP, disabling software debayering";
> +			swIsp_.reset();
> +		} else {
> +			swIsp_->inputBufferReady.connect(this, &SimpleCameraData::conversionInputDone);
> +			swIsp_->outputBufferReady.connect(this, &SimpleCameraData::conversionOutputDone);
> +			swIsp_->ispStatsReady.connect(this, &SimpleCameraData::ispStatsReady);
> +
> +			swIsp_->getSignalSetSensorControls().connect(this, &SimpleCameraData::setSensorControls);
> +		}
> +	}
> +

I guess this needs to be revisited before the merge?

Best regards,
									Pavel
-- 
People of Russia, stop Putin before his war on Ukraine escalates.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <https://lists.libcamera.org/pipermail/libcamera-devel/attachments/20240114/93faff0b/attachment.sig>