[libcamera-devel] [PATCH v2 11/18] libcamera: ipa: add Soft IPA common files

[Andrei Konovalov]

Hi,

On 14.01.2024 20:03, Pavel Machek wrote:
> Hi!
> 
>> new file mode 100644
>> index 00000000..2dae652b
>> --- /dev/null
>> +++ b/include/libcamera/ipa/soft.mojom
>> @@ -0,0 +1,29 @@
>> +/* SPDX-License-Identifier: LGPL-2.1-or-later */
>> +
>> +/*
>> + * \todo Document the interface and remove the related EXCLUDE_PATTERNS entry.
>> + * \todo Add a way to tell SoftIPA the list of params SoftISP accepts?
>> + */
> 
> Are the todos still relevant?

The first todo definitely holds (all the current mojom files have it too).

The second one can be dropped as this was an enhancement I was thinking about, but
haven't progressed on that.

Thanks,
Andrey

> Best regards,
> 									Pavel