[PATCH 3/4] libcamera: vimc: Drop ipa_interface.h header

Milan Zamazal mzamazal at redhat.com
Mon Jul 1 11:04:10 CEST 2024


Umang Jain <umang.jain at ideasonboard.com> writes:

> The ipa_interface.h header is already included in vimc_ipa_interface.h
> generated from module_ipa_interface.h.tmpl. Drop it from the vimc IPA
> and pipeline handler as deemed redundant.
>
> Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>

Reviewed-by: Milan Zamazal <mzamazal at redhat.com>

> ---
>  src/ipa/vimc/vimc.cpp                | 1 -
>  src/libcamera/pipeline/vimc/vimc.cpp | 1 -
>  2 files changed, 2 deletions(-)
>
> diff --git a/src/ipa/vimc/vimc.cpp b/src/ipa/vimc/vimc.cpp
> index ebd63fa6..766e9c9c 100644
> --- a/src/ipa/vimc/vimc.cpp
> +++ b/src/ipa/vimc/vimc.cpp
> @@ -16,7 +16,6 @@
>  #include <libcamera/base/file.h>
>  #include <libcamera/base/log.h>
>  
> -#include <libcamera/ipa/ipa_interface.h>
>  #include <libcamera/ipa/ipa_module_info.h>
>  
>  #include "libcamera/internal/mapped_framebuffer.h"
> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp
> index 0ec9928e..838a9355 100644
> --- a/src/libcamera/pipeline/vimc/vimc.cpp
> +++ b/src/libcamera/pipeline/vimc/vimc.cpp
> @@ -24,7 +24,6 @@
>  #include <libcamera/request.h>
>  #include <libcamera/stream.h>
>  
> -#include <libcamera/ipa/ipa_interface.h>
>  #include <libcamera/ipa/ipa_module_info.h>
>  #include <libcamera/ipa/vimc_ipa_interface.h>
>  #include <libcamera/ipa/vimc_ipa_proxy.h>



More information about the libcamera-devel mailing list