[PATCH 1/4] libcamera: rkisp1: Drop base IPA headers inclusion

[Kieran Bingham]

Quoting Umang Jain (2024-07-01 08:57:17)
> The IPA headers ipa_interface.h and core_ipa_interface.h are
> included as part of the rkisp1_ipa_interface.h generated from
> module_ipa_interface.h.tmpl. Drop them as deemed redundant.

I wonder why these were put in in the first place. Are there any
artificats that would mean we should include them becuase of 'include
what you use' ? But that said - I really can't see a reason to inlcude
the base interface when we include a targetted/specific interface..


Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> 
> Signed-off-by: Umang Jain <umang.jain at ideasonboard.com>
> ---
>  src/ipa/rkisp1/rkisp1.cpp                | 1 -
>  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 -
>  2 files changed, 2 deletions(-)
> 
> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp
> index d31cdbab..a43116d7 100644
> --- a/src/ipa/rkisp1/rkisp1.cpp
> +++ b/src/ipa/rkisp1/rkisp1.cpp
> @@ -19,7 +19,6 @@
>  
>  #include <libcamera/control_ids.h>
>  #include <libcamera/framebuffer.h>
> -#include <libcamera/ipa/ipa_interface.h>
>  #include <libcamera/ipa/ipa_module_info.h>
>  #include <libcamera/ipa/rkisp1_ipa_interface.h>
>  #include <libcamera/request.h>
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> index 4cbf105d..97cd78a7 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> @@ -27,7 +27,6 @@
>  #include <libcamera/stream.h>
>  #include <libcamera/transform.h>
>  
> -#include <libcamera/ipa/core_ipa_interface.h>
>  #include <libcamera/ipa/rkisp1_ipa_interface.h>
>  #include <libcamera/ipa/rkisp1_ipa_proxy.h>
>  
> -- 
> 2.44.0
>