[PATCH 0/4] Frop base IPA headers

[Milan Zamazal]

Laurent Pinchart <laurent.pinchart at ideasonboard.com> writes:

> Hi Milan,
>
> On Mon, Jul 01, 2024 at 11:09:56AM +0200, Milan Zamazal wrote:
>> Umang Jain <umang.jain at ideasonboard.com> writes:
>> 
>> > Small drive by series to drop ipa base headers included in the
>> > pipeline/IPA. These(ipa_interface.h/core_ipa_interface.h) are
>> > already included as part of <module>_ipa_interface.h generated
>> > headers. Drop them as redundant.
>> 
>> Hi Umang,
>> 
>> thank you for the cleanup.
>> 
>> FWIW there are apparently some other include's in the given files that
>> could be removed:
>
> How did you come up with that list, did you use any automated tool ?

They are highlighted as not directly used by LSP in my editor.  If LSP
can identify them then there should probably be a semi-automated way to
find them but I don't know how.

>> diff --git a/src/ipa/ipu3/ipu3.cpp b/src/ipa/ipu3/ipu3.cpp
>> index dca07970..1d9dd40e 100644
>> --- a/src/ipa/ipu3/ipu3.cpp
>> +++ b/src/ipa/ipu3/ipu3.cpp
>> @@ -7,7 +7,6 @@
>>  
>>  #include <algorithm>
>>  #include <array>
>> -#include <cmath>
>>  #include <limits>
>>  #include <map>
>>  #include <memory>
>> @@ -33,7 +32,6 @@
>>  
>>  #include "algorithms/af.h"
>>  #include "algorithms/agc.h"
>> -#include "algorithms/algorithm.h"
>>  #include "algorithms/awb.h"
>>  #include "algorithms/blc.h"
>>  #include "algorithms/tone_mapping.h"
>> diff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp
>> index a43116d7..c6a76720 100644
>> --- a/src/ipa/rkisp1/rkisp1.cpp
>> +++ b/src/ipa/rkisp1/rkisp1.cpp
>> @@ -6,8 +6,6 @@
>>   */
>>  
>>  #include <algorithm>
>> -#include <math.h>
>> -#include <queue>
>>  #include <stdint.h>
>>  #include <string.h>
>>  
>> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
>> index 97cd78a7..b63c048d 100644
>> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
>> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
>> @@ -6,8 +6,6 @@
>>   */
>>  
>>  #include <algorithm>
>> -#include <array>
>> -#include <iomanip>
>>  #include <memory>
>>  #include <numeric>
>>  #include <queue>
>> diff --git a/src/libcamera/pipeline/vimc/vimc.cpp b/src/libcamera/pipeline/vimc/vimc.cpp
>> index 838a9355..3d97fa8c 100644
>> --- a/src/libcamera/pipeline/vimc/vimc.cpp
>> +++ b/src/libcamera/pipeline/vimc/vimc.cpp
>> @@ -6,7 +6,6 @@
>>   */
>>  
>>  #include <algorithm>
>> -#include <iomanip>
>>  #include <map>
>>  #include <math.h>
>>  #include <tuple>
>
>> 
>> > Umang Jain (4):
>> >   libcamera: rkisp1: Drop base IPA headers inclusion
>> >   libcamera: ipa: ipu3: Drop ipa_interface.h header
>> >   libcamera: vimc: Drop ipa_interface.h header
>> >   libcamera: ipa: soft_simple: Drop ipa_interface.h header
>> >
>> >  src/ipa/ipu3/ipu3.cpp                    | 1 -
>> >  src/ipa/rkisp1/rkisp1.cpp                | 1 -
>> >  src/ipa/simple/soft_simple.cpp           | 1 -
>> >  src/ipa/vimc/vimc.cpp                    | 1 -
>> >  src/libcamera/pipeline/rkisp1/rkisp1.cpp | 1 -
>> >  src/libcamera/pipeline/vimc/vimc.cpp     | 1 -
>> >  6 files changed, 6 deletions(-)