[PATCH] ipa: rkisp1: Install all tuning files

[Jacopo Mondi]

Hi Robert

On Wed, Jul 03, 2024 at 09:13:45AM GMT, Robert Mader wrote:
> Or should we maybe just unconditionally install all *.yaml files in this
> folder?
>

I would be suprised if meson allows usage of wildcards when listing
files. In facts, from a very quick test, I get

../src/ipa/rkisp1/data/meson.build:3:13: ERROR: File *.yaml does not exist.)

It's also specified in the FAQ
https://mesonbuild.com/FAQ.html#why-cant-i-specify-target-files-with-a-wildcard

And as suggested in the same webpage, if we really want to, we should
add a tiny scripts that lists all the .yaml file and call it from the
meson build file ? Is it worth it ?


> On 03.07.24 06:52, Robert Mader wrote:
> > We have all these neat tuning files. Unfortunately we forgot to install
> > many of them.
> >
> > Signed-off-by: Robert Mader<robert.mader at collabora.com>
> > ---
> >   src/ipa/rkisp1/data/meson.build | 4 ++++
> >   1 file changed, 4 insertions(+)
> >
> > diff --git a/src/ipa/rkisp1/data/meson.build b/src/ipa/rkisp1/data/meson.build
> > index 7150e155..1e3522b2 100644
> > --- a/src/ipa/rkisp1/data/meson.build
> > +++ b/src/ipa/rkisp1/data/meson.build
> > @@ -2,8 +2,12 @@
> >   conf_files = files([
> >       'imx219.yaml',
> > +    'imx258.yaml',
> > +    'ov2685.yaml',
> >       'ov4689.yaml',
> >       'ov5640.yaml',
> > +    'ov5695.yaml',
> > +    'ov8858.yaml',
> >       'uncalibrated.yaml',
> >   ])
>
> --
> Robert Mader
> Consultant Software Developer
>
> Collabora Ltd.
> Platinum Building, St John's Innovation Park, Cambridge CB4 0DS, UK
> Registered in England & Wales, no. 5513718