[PATCH v2 5/6] ipa: rkisp1: data: Update tuning files for imx219 and imx258

Laurent Pinchart laurent.pinchart at ideasonboard.com
Wed Jul 3 14:45:25 CEST 2024


Hi Stefan,

Thank you for the patch.

On Wed, Jul 03, 2024 at 12:39:52PM +0200, Stefan Klug wrote:
> The black levels for imx219 and imx258 are now contained in the camera
> sensor helpers. Remove them from the tuning file for the imx219. Add a
> BLC entry to the imx258 tuning file.
> 
> Signed-off-by: Stefan Klug <stefan.klug at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  src/ipa/rkisp1/data/imx219.yaml | 4 ----
>  src/ipa/rkisp1/data/imx258.yaml | 1 +
>  2 files changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/src/ipa/rkisp1/data/imx219.yaml b/src/ipa/rkisp1/data/imx219.yaml
> index cbcc43b84ac7..0d99cb529392 100644
> --- a/src/ipa/rkisp1/data/imx219.yaml
> +++ b/src/ipa/rkisp1/data/imx219.yaml
> @@ -6,10 +6,6 @@ algorithms:
>    - Agc:
>    - Awb:
>    - BlackLevelCorrection:
> -      R:  256
> -      Gr: 256
> -      Gb: 256
> -      B:  256
>    - LensShadingCorrection:
>        x-size: [ 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625 ]
>        y-size: [ 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625 ]
> diff --git a/src/ipa/rkisp1/data/imx258.yaml b/src/ipa/rkisp1/data/imx258.yaml
> index 43dddf20dcd2..202af36afbee 100644
> --- a/src/ipa/rkisp1/data/imx258.yaml
> +++ b/src/ipa/rkisp1/data/imx258.yaml
> @@ -5,6 +5,7 @@ version: 1
>  algorithms:
>    - Agc:
>    - Awb:
> +  - BlackLevelCorrection:
>    - LensShadingCorrection:
>        x-size: [ 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625 ]
>        y-size: [ 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625, 0.0625 ]

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list