[PATCH v3 13/23] libtuning: lsc: rkisp1: Clip lsc values to valid range
Paul Elder
paul.elder at ideasonboard.com
Thu Jul 4 11:16:31 CEST 2024
On Wed, Jul 03, 2024 at 04:17:02PM +0200, Stefan Klug wrote:
> Based on the input images, the lsc values could exceed the range allowed
> by the rkisp1. As we are now clipping the values, we can simplify the
> value mapping.
>
> Signed-off-by: Stefan Klug <stefan.klug at ideasonboard.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> ---
> utils/tuning/libtuning/modules/lsc/rkisp1.py | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/utils/tuning/libtuning/modules/lsc/rkisp1.py b/utils/tuning/libtuning/modules/lsc/rkisp1.py
> index 20406e436a6a..57004104fc7a 100644
> --- a/utils/tuning/libtuning/modules/lsc/rkisp1.py
> +++ b/utils/tuning/libtuning/modules/lsc/rkisp1.py
> @@ -80,7 +80,8 @@ class LSCRkISP1(LSC):
> tables = []
> for lis in [list_cr, list_cgr, list_cgb, list_cb]:
> table = np.mean(lis[indices], axis=0)
> - table = output_map_func((1, 3.999), (1024, 4095), table)
> + table = output_map_func((1, 4), (1024, 4096), table)
> + table = np.clip(table, 1024, 4095)
Oh that indeed does look nicer.
Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>
> table = np.round(table).astype('int32').tolist()
> tables.append(table)
>
> --
> 2.43.0
>
More information about the libcamera-devel
mailing list