[PATCH v3 17/23] libtuning: Handle cases, where no lsc tuning images are present

Paul Elder paul.elder at ideasonboard.com
Thu Jul 4 12:30:04 CEST 2024


On Wed, Jul 03, 2024 at 04:17:06PM +0200, Stefan Klug wrote:
> Make it clear that no lsc calibration was done by returning None instead
> of a incomplete configuration.
> 
> Signed-off-by: Stefan Klug <stefan.klug at ideasonboard.com>
> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>

> ---
>  utils/tuning/libtuning/modules/lsc/rkisp1.py | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/utils/tuning/libtuning/modules/lsc/rkisp1.py b/utils/tuning/libtuning/modules/lsc/rkisp1.py
> index 57004104fc7a..512233aeae9d 100644
> --- a/utils/tuning/libtuning/modules/lsc/rkisp1.py
> +++ b/utils/tuning/libtuning/modules/lsc/rkisp1.py
> @@ -107,6 +107,9 @@ class LSCRkISP1(LSC):
>  
>          output['sets'] = self._do_all_lsc(images)
>  
> +        if len(output['sets']) == 0:
> +            return None
> +
>          # \todo Validate images from greyscale camera and force grescale mode
>          # \todo Debug functionality
>  
> -- 
> 2.43.0
> 


More information about the libcamera-devel mailing list