[PATCH v2 2/2] test: utils: Extend utils::hex() test to 8-bit and 16-bit values

Stefan Klug stefan.klug at ideasonboard.com
Thu Jul 4 12:58:29 CEST 2024


Hi Laurent,

Thank you for the patch.

On Thu, Jul 04, 2024 at 01:07:28PM +0300, Laurent Pinchart wrote:
> Now that the utils::hex() function supports 8-bit and 16-bit integers,
> extend the unit test to cover them.
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Stefan Klug <stefan.klug at ideasonboard.com> 

Regards,
Stefan

> ---
>  test/utils.cpp | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
> 
> diff --git a/test/utils.cpp b/test/utils.cpp
> index 41af954b326f..d25475cb93b9 100644
> --- a/test/utils.cpp
> +++ b/test/utils.cpp
> @@ -176,6 +176,14 @@ protected:
>  		std::ostringstream os;
>  		std::string ref;
>  
> +		os << utils::hex(static_cast<int8_t>(0x42)) << " ";
> +		ref += "0x42 ";
> +		os << utils::hex(static_cast<uint8_t>(0x42)) << " ";
> +		ref += "0x42 ";
> +		os << utils::hex(static_cast<int16_t>(0x42)) << " ";
> +		ref += "0x0042 ";
> +		os << utils::hex(static_cast<uint16_t>(0x42)) << " ";
> +		ref += "0x0042 ";
>  		os << utils::hex(static_cast<int32_t>(0x42)) << " ";
>  		ref += "0x00000042 ";
>  		os << utils::hex(static_cast<uint32_t>(0x42)) << " ";
> @@ -184,6 +192,15 @@ protected:
>  		ref += "0x0000000000000042 ";
>  		os << utils::hex(static_cast<uint64_t>(0x42)) << " ";
>  		ref += "0x0000000000000042 ";
> +
> +		os << utils::hex(static_cast<int8_t>(0x42), 6) << " ";
> +		ref += "0x000042 ";
> +		os << utils::hex(static_cast<uint8_t>(0x42), 1) << " ";
> +		ref += "0x42 ";
> +		os << utils::hex(static_cast<int16_t>(0x42), 6) << " ";
> +		ref += "0x000042 ";
> +		os << utils::hex(static_cast<uint16_t>(0x42), 1) << " ";
> +		ref += "0x42 ";
>  		os << utils::hex(static_cast<int32_t>(0x42), 4) << " ";
>  		ref += "0x0042 ";
>  		os << utils::hex(static_cast<uint32_t>(0x42), 1) << " ";
> -- 
> Regards,
> 
> Laurent Pinchart
> 


More information about the libcamera-devel mailing list