[PATCH v2 07/11] pipeline: rkisp1: Use the extensible parameters format
Paul Elder
paul.elder at ideasonboard.com
Fri Jul 5 14:42:39 CEST 2024
On Thu, Jul 04, 2024 at 07:20:31PM +0300, Laurent Pinchart wrote:
> From: Jacopo Mondi <jacopo.mondi at ideasonboard.com>
>
> Now that the IPA module supports the extensible parameters format,
> switch to it when available. If the kernel driver doesn't support the
> new format, setFormat() will adjust paramFormat to the legacy format,
> which will be passed to the IPA module, preserving backward
> compatibility.
>
> Signed-off-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
> Reviewed-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>
> ---
> src/libcamera/pipeline/rkisp1/rkisp1.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1.cpp b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> index f5c01a2566d2..177ded134dbc 100644
> --- a/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> +++ b/src/libcamera/pipeline/rkisp1/rkisp1.cpp
> @@ -799,7 +799,7 @@ int PipelineHandlerRkISP1::configure(Camera *camera, CameraConfiguration *c)
> }
>
> V4L2DeviceFormat paramFormat;
> - paramFormat.fourcc = V4L2PixelFormat(V4L2_META_FMT_RK_ISP1_PARAMS);
> + paramFormat.fourcc = V4L2PixelFormat(V4L2_META_FMT_RK_ISP1_EXT_PARAMS);
> ret = param_->setFormat(¶mFormat);
> if (ret)
> return ret;
More information about the libcamera-devel
mailing list