[PATCH v1] libipa: camera_sensor_helper: Add OV5675 black level

[Daniel Semkowicz]

True, I missed it... Thanks!

I will upload v2 with value from kernel driver.


On Tue, Jul 23, 2024 at 4:39 PM Kieran Bingham
<kieran.bingham at ideasonboard.com> wrote:
>
> Quoting Daniel Semkowicz (2024-07-23 15:17:58)
> > Add black level value for OV5675 camera.
> > According to datasheet, default value is 0x10, 10 bits width.
>
> I don't have that datasheet, but given the above statement the below is
> correct:
>
>
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
>
> >
> > Signed-off-by: Daniel Semkowicz <dse at thaumatec.com>
> > ---
> >  src/ipa/libipa/camera_sensor_helper.cpp | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp
> > index a1339c83..79608c00 100644
> > --- a/src/ipa/libipa/camera_sensor_helper.cpp
> > +++ b/src/ipa/libipa/camera_sensor_helper.cpp
> > @@ -601,6 +601,8 @@ class CameraSensorHelperOv5675 : public CameraSensorHelper
> >  public:
> >         CameraSensorHelperOv5675()
> >         {
> > +               /* From datasheet: 0x10 at 10bits. */
> > +               blackLevel_ = 1024;
> >                 gainType_ = AnalogueGainLinear;
> >                 gainConstants_.linear = { 1, 0, 0, 128 };
> >         }
> > --
> > 2.45.2
> >
> >