[PATCH v2] libipa: camera_sensor_helper: Add OV5675 black level

[Kieran Bingham]

Quoting Quentin Schulz (2024-07-23 16:04:39)
> Hi Daniel,
> 
> On 7/23/24 4:56 PM, Daniel Semkowicz wrote:
> > Add black level value for OV5675 camera sensor.
> > According to datasheet, default value is 0x10, 10 bits width.
> > However, Linux kernel driver initializes black level target value
> > to 0x40. Set the value to the same as in kernel driver, but scaled
> > to 16 bits.
> > 
> > Signed-off-by: Daniel Semkowicz <dse at thaumatec.com>
> 
> Reviewed-by: Quentin Schulz <quentin.schulz at cherry.de>
> 
> Considering that this value can change over time, c.f. 
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=99cd12425dfe9a400b672f112512a3678dfd1eb6 
> for ov5670, we should probably think of having the kernel expose this 
> value as Kieran suggested in v1. I don't think this should be a blocker 
> for this patch though (especially since the upstream kernel has had this 
> value since the introducing commit).

Agreed,

This value matches what upstream kernels will configure the device so
it's appropriate now.

But we need to resolve this in the future - ideally for all camera
sensors in a consistent manner. That's far more tricky :D

but for this v2 patch ...



Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

> 
> Thanks!
> Quentin