Software ISP TODOs

[Laurent Pinchart]

Hi Milan,

On Tue, Jul 30, 2024 at 04:13:52PM +0200, Milan Zamazal wrote:
> Hi,
> 
> I have been working on some of the software ISP TODOs, here is an

Thank you for that.

> overview of the current state, FYI.  See
> https://git.libcamera.org/libcamera/libcamera.git/tree/src/libcamera/software_isp/TODO
> for descriptions of the TODOs.
> 
> *
> 
> 1. Setting F_SEAL_SHRINK and F_SEAL_GROW after ftruncate()
> 
> Better to be addressed by someone who fully understands what's the right
> thing to do.

Done.

> *
> 
> 2. Reconsider stats sharing
> 
> 3. Remove statsReady signal
> 
> 5. Store ISP parameters in per-frame buffers
> 
> #2 + #5 part of the patches I work on (not yet posted but working for
> me), maybe I'll handle #3 too, it's all WIP.
> 
> *
> 
> 6. Input buffer copying configuration
> 
> 7. Performance measurement configuration
> 
> Part of the posted global configuration file patches.
> 
> *
> 
> 8. DebayerCpu cleanups
> 
> This is partially addressed by my patches, which compute the lookup
> tables elsewhere and get rid of getStatsFd method at least.  But
> DebayerCpu still keeps gathering stats, I don't think we can do much
> about it.  I'd keep this TODO restricted to what can be reasonably done.
> Let's also see what Bryan invents while working on DebayerGpu.

Fine with me.

> *
> 
> 8. Decouple pipeline and IPA naming
> 
> Better to be addressed by someone who knows what's the right thing to
> do.
> 
> *
> 
> 9. Doxyfile cleanup
> 
> Not yet handled.
> 
> *
> 
> 10. Switch to libipa/algorithm.h API in processStats
> 
> 11. Improve handling the sensor controls which take effect with a delay
> 
> 12. Use DelayedControls class in ispStatsReady()
> 
> Part of the posted software ISP refactoring patches.
> 
> *
> 
> 13. Improve black level and colour gains application
> 
> I don't think we know how to resolve this (it's similar to #8 Debayer
> cleanups) and I don't see this as urgent (e.g. the refactoring related
> to #10-#12 is way more important for further work on software ISP).

Let's check again once the other improvements land.

-- 
Regards,

Laurent Pinchart