[PATCH v2 2/3] libcamera: ipa_proxy: Unify configurationFile argument name

Laurent Pinchart laurent.pinchart at ideasonboard.com
Wed Jul 31 11:25:26 CEST 2024


On Wed, Jul 31, 2024 at 10:19:46AM +0100, Kieran Bingham wrote:
> Quoting Milan Zamazal (2024-07-08 13:38:02)
> > The argument name is different in the declaration and the definition.
> > Let's use the same one in both, namely `name'.
> > 
> > Signed-off-by: Milan Zamazal <mzamazal at redhat.com>
> 
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> > ---
> >  include/libcamera/internal/ipa_proxy.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/include/libcamera/internal/ipa_proxy.h b/include/libcamera/internal/ipa_proxy.h
> > index ed6a5bcf..5240f69f 100644
> > --- a/include/libcamera/internal/ipa_proxy.h
> > +++ b/include/libcamera/internal/ipa_proxy.h
> > @@ -31,7 +31,7 @@ public:
> >  
> >         bool isValid() const { return valid_; }
> >  
> > -       std::string configurationFile(const std::string &file) const;
> > +       std::string configurationFile(const std::string &name) const;
> >  
> >  protected:
> >         std::string resolvePath(const std::string &file) const;

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list