[PATCH v2 4/4] libcamera: software_isp: Remove file seal TODO item

Laurent Pinchart laurent.pinchart at ideasonboard.com
Wed Jul 31 15:59:36 CEST 2024


The file seal TODO item has been addressed. Remove it.

Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Reviewed-by: Milan Zamazal <mzamazal at redhat.com>
Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
---
 src/libcamera/software_isp/TODO | 19 -------------------
 1 file changed, 19 deletions(-)

diff --git a/src/libcamera/software_isp/TODO b/src/libcamera/software_isp/TODO
index 6bdc590531ca..9978afc0317b 100644
--- a/src/libcamera/software_isp/TODO
+++ b/src/libcamera/software_isp/TODO
@@ -1,22 +1,3 @@
-1. Setting F_SEAL_SHRINK and F_SEAL_GROW after ftruncate()
-
->> SharedMem::SharedMem(const std::string &name, std::size_t size)
->> 	: name_(name), size_(size), mem_(nullptr)
->>
->> ...
->>
->> 	if (ftruncate(fd_.get(), size_) < 0)
->> 		return;
->
-> Should we set the GROW and SHRINK seals (in a separate patch) ?
-
-Yes, this can be done.
-Setting F_SEAL_SHRINK and F_SEAL_GROW after the ftruncate() call above could catch
-some potential errors related to improper access to the shared memory allocated by
-the SharedMemObject.
-
----
-
 2. Reconsider stats sharing
 
 >>> +void SwStatsCpu::finishFrame(void)
-- 
Regards,

Laurent Pinchart



More information about the libcamera-devel mailing list