[PATCH v2 0/4] libcamera: Address soft ISP file seal TODO item

Milan Zamazal mzamazal at redhat.com
Wed Jul 31 16:56:06 CEST 2024


Laurent Pinchart <laurent.pinchart at ideasonboard.com> writes:

> Hello,
>
> This small series addresses one TODO item of the soft ISP, namely shrink
> and grow sealing of the memfd underlying SharedMem objects.
>
> Patch 1/4 starts by sharing the memfd handling code between the
> DmaBufAllocator and SharedMem classes by moving it to a new MemFd helper
> class. Patch 2/4 then applies a suggestion from Nicolas to improve code
> readability. Patch 3/4 addresses the TODO item, and patch 4/4 finally
> drops it from the TODO file.
>
> Could someone test this with the soft ISP to make sure I haven't broken
> anything ?

Tested-by: Milan Zamazal <mzamazal at redhat.com>

> Laurent Pinchart (4):
>   libcamera: base: Add MemFd helper class
>   libcamera: base: memfd: Handle uClibc compatibility with function
>     wrapper
>   libcamera: shared_mem_object: Prevent memfd from shrinking or growing
>   libcamera: software_isp: Remove file seal TODO item
>
>  include/libcamera/base/memfd.h      |  34 ++++++++
>  include/libcamera/base/meson.build  |   1 +
>  src/libcamera/base/memfd.cpp        | 123 ++++++++++++++++++++++++++++
>  src/libcamera/base/meson.build      |   1 +
>  src/libcamera/dma_buf_allocator.cpp |  46 +----------
>  src/libcamera/shared_mem_object.cpp |  22 ++---
>  src/libcamera/software_isp/TODO     |  19 -----
>  7 files changed, 169 insertions(+), 77 deletions(-)
>  create mode 100644 include/libcamera/base/memfd.h
>  create mode 100644 src/libcamera/base/memfd.cpp
>
>
> base-commit: 98b01768397f982bd177b55e9bc67002b645b4d0



More information about the libcamera-devel mailing list