[PATCH] ipa: rpi: Disable StatsOutputEnable control by default

[David Plowman]

Hi Naush

Thanks for the fix!

On Mon, 3 Jun 2024 at 10:49, Kieran Bingham
<kieran.bingham at ideasonboard.com> wrote:
>
> Quoting Naushir Patuck (2024-06-03 10:42:09)
> > Set the default value of controls::rpi::StatsOutputEnable to false,
> > disabling the functionality. This stops unnecessary copies of the
> > statistics output ending up in the Request metdata if not needed.
>
> Default false here is certainly reasonable.
>
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
>
> >
> > Signed-off-by: Naushir Patuck <naush at raspberrypi.com>

Reviewed-by: David Plowman <david.plowman at raspberrypi.com>

David

> > ---
> >  src/ipa/rpi/common/ipa_base.cpp | 7 ++++---
> >  1 file changed, 4 insertions(+), 3 deletions(-)
> >
> > diff --git a/src/ipa/rpi/common/ipa_base.cpp b/src/ipa/rpi/common/ipa_base.cpp
> > index 1d12262bda01..6fb90209aa0f 100644
> > --- a/src/ipa/rpi/common/ipa_base.cpp
> > +++ b/src/ipa/rpi/common/ipa_base.cpp
> > @@ -73,7 +73,7 @@ const ControlInfoMap::Map ipaControls{
> >         { &controls::ScalerCrop, ControlInfo(Rectangle{}, Rectangle(65535, 65535, 65535, 65535), Rectangle{}) },
> >         { &controls::FrameDurationLimits, ControlInfo(INT64_C(33333), INT64_C(120000)) },
> >         { &controls::draft::NoiseReductionMode, ControlInfo(controls::draft::NoiseReductionModeValues) },
> > -       { &controls::rpi::StatsOutputEnable, ControlInfo(false, true) },
> > +       { &controls::rpi::StatsOutputEnable, ControlInfo(false, true, false) },
> >  };
> >
> >  /* IPA controls handled conditionally, if the sensor is not mono */
> > @@ -103,8 +103,9 @@ LOG_DEFINE_CATEGORY(IPARPI)
> >  namespace ipa::RPi {
> >
> >  IpaBase::IpaBase()
> > -       : controller_(), frameLengths_(FrameLengthsQueueSize, 0s), stitchSwapBuffers_(false), frameCount_(0),
> > -         mistrustCount_(0), lastRunTimestamp_(0), firstStart_(true), flickerState_({ 0, 0s })
> > +       : controller_(), frameLengths_(FrameLengthsQueueSize, 0s), statsMetadataOutput_(false),
> > +         stitchSwapBuffers_(false), frameCount_(0), mistrustCount_(0), lastRunTimestamp_(0),
> > +         firstStart_(true), flickerState_({ 0, 0s })
> >  {
> >  }
> >
> > --
> > 2.34.1
> >