[PATCH 1/2] clang-format: Make Qt includes matching case sensitive

[Milan Zamazal]

Hi Laurent,

thank you for review.

Laurent Pinchart <laurent.pinchart at ideasonboard.com> writes:

> Hi Milan,
>
> Thank you for the patch.
>
> On Mon, Jun 10, 2024 at 08:08:49PM +0200, Milan Zamazal wrote:
>> This fixes the problem that includes like
>> 
>>   #include <queue>
>> 
>> are put near the end.
>> 
>> Signed-off-by: Milan Zamazal <mzamazal at redhat.com>
>> ---
>>  .clang-format | 1 +
>>  1 file changed, 1 insertion(+)
>> 
>> diff --git a/.clang-format b/.clang-format
>> index cac7029f..b48d4e1e 100644
>> --- a/.clang-format
>> +++ b/.clang-format
>> @@ -75,6 +75,7 @@ IncludeCategories:
>>      Priority:        9
>>    # Qt includes (match before C++ standard library)
>>    - Regex:           '<Q([A-Za-z0-9\-_])+>'
>> +    CaseSensitive:   true
>
> This option is available in clang-format 12 and later. There are no
> distribution versions we specifically care about that ship a too old
> clang-formation version (Debian buster ships 11 by default but has a
> clang-format-13 package), so this is fine. We should however update the
> comment at the beginning of the file to indicate this. I can handle it
> when applying this patch.

Yes, please do.

> Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
>
> By the way, see commit d1cdaeb6f078677d5bf46cb596102bfe8da070b9 :-)

I see, thanks for explanation.

>>      Priority:        9
>>    # Headers in <> with an extension. (+system libraries)
>>    - Regex:           '<([A-Za-z0-9\-_])+\.h>'

[...]

>> On Mon, Jun 10, 2024 at 08:08:49PM +0200, Milan Zamazal wrote:
>> > This fixes the problem that includes like
>
> I will also expand this to
>
>     Now that stable versions of all major distributions ship clang-format 12
>     or newer, we can use the CaseSensitive option for the Qt include
>     category. This fixes the problem that includes like
>
> to add more context.

OK, thank you.

>> > 
>> >   #include <queue>
>> > 
>> > are put near the end.

[...]