[PATCH v7 2/4] ipa: libipa: Copy pwl from rpi

[Kieran Bingham]

Quoting Paul Elder (2024-06-11 10:58:15)
> On Tue, Jun 11, 2024 at 03:00:41AM +0300, Laurent Pinchart wrote:
> > Hi Paul,
> > 
> > Thank you for the patch.
> > 
> > On Mon, Jun 10, 2024 at 11:19:39PM +0900, Paul Elder wrote:
> > > Copy the piecewise linear function code from Raspberry Pi.
> > > 
> > > Signed-off-by: Paul Elder <paul.elder at ideasonboard.com>
> > > Reviewed-by: Stefan Klug <stefan.klug at ideasonboard.com>
> > > Acked-by: David Plowman <david.plowman at raspberrypi.com>
> > > Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> > 
> > This will break bisection due to missing documentation. Is that an issue
> > ? Should we squash patches 2/4 and 3/4 ?
> 
> If we squash then we can't tell what changed, so it depends on if that
> is more valuable or if maintaining bisection is more valuable.
> 
> Or we say that the former is only important for review and it's fine to
> squash.

I would say definitely valuable for review, so a valuable split to start
with and I'm fine if it's preferred to squash for bisectability.

--
Kieran