[PATCH 1/6] ipa: rkisp1: goc: Fix typographical issues in documentation.

Stefan Klug stefan.klug at ideasonboard.com
Wed Jun 12 09:17:23 CEST 2024


Hi Laurent,

thank you for the fixup.

On Wed, Jun 12, 2024 at 12:20:56AM +0300, Laurent Pinchart wrote:
> Fix a few assorted typographical issues:
> 
> - Sentences should end with a period.
> - Paragraphs should be separated by a blank line, and there should be no
>   line break within a paragraph.
> - Doxygen lists need a list marker ('-' or '*', use '-' here).
> 
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

Reviewed-by: Stefan Klug <stefan.klug at ideasonboard.com> 

Stefan

> ---
>  src/ipa/rkisp1/algorithms/goc.cpp | 9 +++++----
>  1 file changed, 5 insertions(+), 4 deletions(-)
> 
> diff --git a/src/ipa/rkisp1/algorithms/goc.cpp b/src/ipa/rkisp1/algorithms/goc.cpp
> index 0201a59deba3..fc5ad9f9177e 100644
> --- a/src/ipa/rkisp1/algorithms/goc.cpp
> +++ b/src/ipa/rkisp1/algorithms/goc.cpp
> @@ -29,15 +29,16 @@ namespace ipa::rkisp1::algorithms {
>   * \class GammaOutCorrection
>   * \brief RkISP1 Gamma out correction
>   *
> - * This algorithm implements the gamma out curve for the RkISP1.
> - * It defaults to a gamma value of 2.2
> + * This algorithm implements the gamma out curve for the RkISP1. It defaults to
> + * a gamma value of 2.2.
> + *
>   * As gamma is internally represented as a piecewise linear function with only
>   * 17 knots, the difference between gamma=2.2 and sRGB gamma is minimal.
>   * Therefore sRGB gamma was not implemented as special case.
>   *
>   * Useful links:
> - * https://www.cambridgeincolour.com/tutorials/gamma-correction.htm
> - * https://en.wikipedia.org/wiki/SRGB
> + * - https://www.cambridgeincolour.com/tutorials/gamma-correction.htm
> + * - https://en.wikipedia.org/wiki/SRGB
>   */
>  
>  LOG_DEFINE_CATEGORY(RkISP1Gamma)
> -- 
> Regards,
> 
> Laurent Pinchart
> 


More information about the libcamera-devel mailing list