[PATCH 4/6] ipa: rkisp1: goc: Mark default gamma table as static constexpr
Stefan Klug
stefan.klug at ideasonboard.com
Wed Jun 12 09:42:18 CEST 2024
Hi Laurent,
thank you for the patch. This was actually mentioned by Jacopo and I
missed it. Sorry for that.
On Wed, Jun 12, 2024 at 12:20:59AM +0300, Laurent Pinchart wrote:
> The values for the default gamma table are stored in an array that is
> never modified. Mark it as static constexpr to facilitate optimizations.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Reviewed-by: Stefan Klug <stefan.klug at ideasonboard.com>
Cheers,
Stefan
> ---
> src/ipa/rkisp1/algorithms/goc.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/ipa/rkisp1/algorithms/goc.cpp b/src/ipa/rkisp1/algorithms/goc.cpp
> index 65460eb45135..e98c9526722f 100644
> --- a/src/ipa/rkisp1/algorithms/goc.cpp
> +++ b/src/ipa/rkisp1/algorithms/goc.cpp
> @@ -108,7 +108,7 @@ void GammaOutCorrection::prepare(IPAContext &context,
> * The logarithmic segments as specified in the reference.
> * Plus an additional 0 to make the loop easier
> */
> - std::array<unsigned, RKISP1_CIF_ISP_GAMMA_OUT_MAX_SAMPLES_V10> segments = {
> + static constexpr std::array<unsigned int, RKISP1_CIF_ISP_GAMMA_OUT_MAX_SAMPLES_V10> segments = {
> 64, 64, 64, 64, 128, 128, 128, 128, 256,
> 256, 256, 512, 512, 512, 512, 512, 0
> };
> --
> Regards,
>
> Laurent Pinchart
>
More information about the libcamera-devel
mailing list