[PATCH] utils: libtuning: Correct GBRG Image parsing

Laurent Pinchart laurent.pinchart at ideasonboard.com
Thu Jun 13 18:10:57 CEST 2024


Hi Dan,

Thank you for the patch.

On Thu, Jun 13, 2024 at 04:09:50PM +0100, Daniel Scally wrote:
> The Image class incorrectly parses data in GBRG bayer formats as the
> indices to the channels are set incorrectly - fix it.
> 
> Signed-off-by: Daniel Scally <dan.scally at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  utils/tuning/libtuning/image.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/utils/tuning/libtuning/image.py b/utils/tuning/libtuning/image.py
> index e2181b11..6ff60ec1 100644
> --- a/utils/tuning/libtuning/image.py
> +++ b/utils/tuning/libtuning/image.py
> @@ -79,7 +79,7 @@ class Image:
>          # is R, then G, then G, then B.
>          bayer_case = {
>              '0 1 1 2': (lt.Color.R, lt.Color.GR, lt.Color.GB, lt.Color.B),
> -            '1 2 0 1': (lt.Color.GB, lt.Color.R, lt.Color.B, lt.Color.GR),
> +            '1 2 0 1': (lt.Color.GB, lt.Color.B, lt.Color.R, lt.Color.GR),
>              '2 1 1 0': (lt.Color.B, lt.Color.GB, lt.Color.GR, lt.Color.R),
>              '1 0 2 1': (lt.Color.GR, lt.Color.R, lt.Color.B, lt.Color.GB)
>          }

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list