[PATCH 00/12] ipa: rkisp1: Miscellaneous AGC fixes

Laurent Pinchart laurent.pinchart at ideasonboard.com
Sun Jun 16 18:38:58 CEST 2024


Hello,

This patch series contains a set of assorted AGC fixes and enhancements
for the rkisp1, as well as the agc_mean_luminance helper.

Patch 01/12 fixes a regression in the recently merged histogram weights
support. It should be fast-tracked, as the master branch is currently
broken for users who don't have AE metering modes in their tuning file.

There's not much else to be said about the series here, please see
individual patches for details.

Laurent Pinchart (12):
  ipa: rkisp1: agc: Fix initialization without metering modes
  ipa: libipa: agc_mean_luminance: Fix enumerator names
  ipa: libipa: agc_mean_luminance: Include missing header
  ipa: rkisp1: Document all AGC parameters in IPAActiveState
  ipa: rkisp1: Document all AGC parameters in IPAFrameContext
  ipa: rkisp1: agc: Make size argument to computeHistogramPredivider
    const
  ipa: rkisp1: agc: Don't update histogram parameters unnecessarily
  ipa: rkisp1: agc: Simplify predivider calculation
  ipa: rkisp1: agc: Use mode from frame context to calculate new EV
  ipa: rkisp1: agc: Rename maxShutterSpeed to maxFrameDuration
  ipa: rkisp1: agc: Correctly clamp maximum shutter speed
  ipa: rkisp1: agc: Move AeEnable control to the AGC algorithm

 src/ipa/libipa/agc_mean_luminance.cpp | 10 ++---
 src/ipa/libipa/agc_mean_luminance.h   |  6 ++-
 src/ipa/rkisp1/algorithms/agc.cpp     | 44 ++++++++-----------
 src/ipa/rkisp1/algorithms/agc.h       |  2 +-
 src/ipa/rkisp1/ipa_context.cpp        | 62 ++++++++++++++++++++++++---
 src/ipa/rkisp1/ipa_context.h          |  4 +-
 src/ipa/rkisp1/rkisp1.cpp             |  1 -
 7 files changed, 85 insertions(+), 44 deletions(-)


base-commit: d978832d9e987b555be7c0ee8eeda37981924515
-- 
Regards,

Laurent Pinchart



More information about the libcamera-devel mailing list