[PATCH 1/3] ipa: simple: softisp: Extend to pass metadata

[Kieran Bingham]

Quoting Kieran Bingham (2024-06-18 00:25:23)
> Extend the Simple IPA IPC to support returning a metadata controllist
> when the process call has completed.
> 
> For efficiency, use the existing signal setIspParams() directly
> to avoid having an extra async callback to return the metadata.
> 
> Merge the metadata reported by the ISP into any completing
> request to provide to the application.
> 
> This should be further extended or improved to make use of the frame
> context structures so that the metadata is tied to a specific frame and
> request completion.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> ---
>  include/libcamera/internal/software_isp/software_isp.h | 5 ++++-
>  include/libcamera/ipa/soft.mojom                       | 2 +-
>  src/ipa/simple/soft_simple.cpp                         | 4 +++-
>  src/libcamera/pipeline/simple/simple.cpp               | 7 +++++--
>  src/libcamera/software_isp/software_isp.cpp            | 6 ++++--
>  5 files changed, 17 insertions(+), 7 deletions(-)
> 
> diff --git a/include/libcamera/internal/software_isp/software_isp.h b/include/libcamera/internal/software_isp/software_isp.h
> index c5338c05b99b..2631f40ef22a 100644
> --- a/include/libcamera/internal/software_isp/software_isp.h
> +++ b/include/libcamera/internal/software_isp/software_isp.h
> @@ -80,8 +80,10 @@ public:
>         Signal<> ispStatsReady;
>         Signal<const ControlList &> setSensorControls;
>  
> +       const ControlList &metadata() { return metadata_; }
> +

And of course this fails CI because I failed to document this new
addition:

https://gitlab.freedesktop.org/camera/libcamera/-/jobs/60009854

/builds/camera/libcamera/include/libcamera/internal/software_isp/software_isp.h:83: error: Member metadata() (function) of class libcamera::SoftwareIsp is not documented. (warning treated as error, aborting now)

--
Kieran