[PATCH] ipa: libipa: matrix: Fix incorrect symbol namespace
Paul Elder
paul.elder at ideasonboard.com
Mon Jun 24 08:06:19 CEST 2024
On Fri, Jun 21, 2024 at 06:23:34PM +0300, Laurent Pinchart wrote:
> The matrixVlidateYaml() function is declared in the libcamera::ipa::
s/Vlidate/Validate/
> namespace, but defined in the libcamera:: namespace. This causes a
> dynamic linking error at runtime. Fix it by moving the function
> definition.
Oops...
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Reviewed-by: Paul Elder <paul.elder at ideasonboard.com>
> ---
> src/ipa/libipa/matrix.cpp | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/ipa/libipa/matrix.cpp b/src/ipa/libipa/matrix.cpp
> index 7f000382d33b..8346f0d34160 100644
> --- a/src/ipa/libipa/matrix.cpp
> +++ b/src/ipa/libipa/matrix.cpp
> @@ -122,8 +122,6 @@ namespace ipa {
> * \return Matrix sum of matrices \a m1 and \a m2
> */
>
> -} /* namespace ipa */
> -
> #ifndef __DOXYGEN__
> /*
> * The YAML data shall be a list of numerical values. Its size shall be equal
> @@ -146,4 +144,6 @@ bool matrixValidateYaml(const YamlObject &obj, unsigned int size)
> }
> #endif /* __DOXYGEN__ */
>
> +} /* namespace ipa */
> +
> } /* namespace libcamera */
More information about the libcamera-devel
mailing list