[PATCH 08/10] test: ipc: unixsocket: Define local function in anonymous namespace
Kieran Bingham
kieran.bingham at ideasonboard.com
Mon Jun 24 23:40:22 CEST 2024
Quoting Laurent Pinchart (2024-06-24 20:29:39)
> A local function in the unixsocket test is defined in the global
> namespace without the static keyword. This compiles fine for now, but
> will cause a missing declaration warning when we enable them. To prepare
> for that, enclose the function declaration in an anonymous namespace.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
> ---
> test/ipc/unixsocket.cpp | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/test/ipc/unixsocket.cpp b/test/ipc/unixsocket.cpp
> index f44ab9c90e25..2546882da085 100644
> --- a/test/ipc/unixsocket.cpp
> +++ b/test/ipc/unixsocket.cpp
> @@ -34,6 +34,8 @@ using namespace libcamera;
> using namespace std;
> using namespace std::chrono_literals;
>
> +namespace {
> +
> int calculateLength(int fd)
> {
> lseek(fd, 0, 0);
> @@ -43,6 +45,8 @@ int calculateLength(int fd)
> return size;
> }
>
> +} /* namespace */
> +
> class UnixSocketTestSlave
> {
> public:
> --
> Regards,
>
> Laurent Pinchart
>
More information about the libcamera-devel
mailing list