[PATCH v2 1/6] libcamera: mali-c55: Limit max size to sensor resolution
Jacopo Mondi
jacopo.mondi at ideasonboard.com
Tue Jun 25 21:04:14 CEST 2024
The Mali C55 ISP cannot upscale. The maximum allowed output size
is the sensor's resolution.
For RAW streams this is already handled in adjustRawSizes(), while
for processed streams the maximum allowed resolution was wrongly
set to the ISP maximum output size (8192x8192).
Signed-off-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>
Signed-off-by: Daniel Scally <dan.scally at ideasonboard.com>
Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
---
src/libcamera/pipeline/mali-c55/mali-c55.cpp | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp
index 45c71c1dd619..1c1fef2337f0 100644
--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp
+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp
@@ -342,7 +342,11 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate()
rawConfig = &config;
}
- Size maxSize = kMaliC55MaxSize;
+ /*
+ * The C55 can not upscale. Limit the configuration to the ISP
+ * capabilities and the sensor resolution.
+ */
+ Size maxSize = kMaliC55MaxSize.boundedTo(data_->resolution());
if (rawConfig) {
/*
* \todo Take into account the Bayer components ordering once
--
2.45.2
More information about the libcamera-devel
mailing list