[PATCH v3 9/9] libcamera: mali-c55: Propagate CSI-2 format to ISP

Jacopo Mondi jacopo.mondi at ideasonboard.com
Wed Jun 26 16:03:05 CEST 2024


The latest version of the Mali C55 driver has changed the format
accepted by the ISP sink pad to be the 20-bit wide.

The CSI-2 receiver handles the format expansion internally by
propagating the sensor produced format from its sink to the 20-bit
expanded version on its source pad.

Instead of re-applying the sensor format to the CSI-2 receiver source
pad (which is now an invalid operation) read from there the format
propagated by the driver internally and further propagate it to the ISP
subdevice.

Signed-off-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>

---
Latest version of the Mali C55 support
https://lore.kernel.org/linux-media/20240529152858.183799-1-dan.scally@ideasonboard.com/
---
 src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp
index 28ad0172658c..156560c1d9bf 100644
--- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp
+++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp
@@ -768,7 +768,7 @@ int PipelineHandlerMaliC55::configure(Camera *camera,
 		if (ret)
 			return ret;
 
-		ret = data->csi_->setFormat(1, &subdevFormat);
+		ret = data->csi_->getFormat(1, &subdevFormat);
 		if (ret)
 			return ret;
 	}
-- 
2.45.2



More information about the libcamera-devel mailing list