[PATCH 01/19] libcamera: software_isp: Remove superfluous includes

Umang Jain umang.jain at ideasonboard.com
Fri Jun 28 05:30:58 CEST 2024


Hi Milan,

Thank you for the patch.

On 26/06/24 12:50 pm, Milan Zamazal wrote:
> Signed-off-by: Milan Zamazal <mzamazal at redhat.com>

nit: One line in commit message body is usually nice-to-have. For instance,

"Remove unused libcamera internal headers bayer_format.h, framebuffer.h 
and mapped_frameBuffer.h."

Otherwise,

Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>
> ---
>   src/libcamera/software_isp/software_isp.cpp | 3 ---
>   1 file changed, 3 deletions(-)
>
> diff --git a/src/libcamera/software_isp/software_isp.cpp b/src/libcamera/software_isp/software_isp.cpp
> index 20fb6f48..08a1afcc 100644
> --- a/src/libcamera/software_isp/software_isp.cpp
> +++ b/src/libcamera/software_isp/software_isp.cpp
> @@ -16,10 +16,7 @@
>   #include <libcamera/formats.h>
>   #include <libcamera/stream.h>
>   
> -#include "libcamera/internal/bayer_format.h"
> -#include "libcamera/internal/framebuffer.h"
>   #include "libcamera/internal/ipa_manager.h"
> -#include "libcamera/internal/mapped_framebuffer.h"
>   #include "libcamera/internal/software_isp/debayer_params.h"
>   
>   #include "debayer_cpu.h"



More information about the libcamera-devel mailing list