[PATCH 02/19] libcamera: software_isp: Move BlackLevel to libcamera::ipa::soft

Umang Jain umang.jain at ideasonboard.com
Fri Jun 28 05:32:00 CEST 2024


Hi Milan,

Thank you for the patch.

On 26/06/24 12:50 pm, Milan Zamazal wrote:
> To be in the same namespace as the other software ISP IPA stuff.
>
> Signed-off-by: Milan Zamazal <mzamazal at redhat.com>

LGTM,

Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>
> ---
>   src/ipa/simple/black_level.cpp | 5 +++++
>   src/ipa/simple/black_level.h   | 4 ++++
>   2 files changed, 9 insertions(+)
>
> diff --git a/src/ipa/simple/black_level.cpp b/src/ipa/simple/black_level.cpp
> index cc490eb5..37e0109c 100644
> --- a/src/ipa/simple/black_level.cpp
> +++ b/src/ipa/simple/black_level.cpp
> @@ -15,6 +15,8 @@ namespace libcamera {
>   
>   LOG_DEFINE_CATEGORY(IPASoftBL)
>   
> +namespace ipa::soft {
> +
>   /**
>    * \class BlackLevel
>    * \brief Object providing black point level for software ISP
> @@ -85,4 +87,7 @@ void BlackLevel::update(SwIspStats::Histogram &yHistogram)
>   		}
>   	};
>   }
> +
> +} /* namespace ipa::soft */
> +
>   } /* namespace libcamera */
> diff --git a/src/ipa/simple/black_level.h b/src/ipa/simple/black_level.h
> index 5e032f9f..a04230c9 100644
> --- a/src/ipa/simple/black_level.h
> +++ b/src/ipa/simple/black_level.h
> @@ -14,6 +14,8 @@
>   
>   namespace libcamera {
>   
> +namespace ipa::soft {
> +
>   class BlackLevel
>   {
>   public:
> @@ -26,4 +28,6 @@ private:
>   	bool blackLevelSet_;
>   };
>   
> +} /* namespace ipa::soft */
> +
>   } /* namespace libcamera */



More information about the libcamera-devel mailing list