[PATCH v2 16/25] libtuning: Handle cases, where no lsc tuning images are present

Laurent Pinchart laurent.pinchart at ideasonboard.com
Sat Jun 29 01:51:54 CEST 2024


Hi Stefan,

Thank you for the patch.

On Fri, Jun 28, 2024 at 12:47:09PM +0200, Stefan Klug wrote:
> Make it clear that no lsc calibration was done by returning None instead
> of a incomplete configuration.
> 
> Signed-off-by: Stefan Klug <stefan.klug at ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  utils/tuning/libtuning/modules/lsc/rkisp1.py | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/utils/tuning/libtuning/modules/lsc/rkisp1.py b/utils/tuning/libtuning/modules/lsc/rkisp1.py
> index 074f3b272dbf..5874f10c936f 100644
> --- a/utils/tuning/libtuning/modules/lsc/rkisp1.py
> +++ b/utils/tuning/libtuning/modules/lsc/rkisp1.py
> @@ -107,6 +107,9 @@ class LSCRkISP1(LSC):
>  
>          output['sets'] = self._do_all_lsc(images)
>  
> +        if len(output['sets']) == 0:
> +            return None
> +
>          # \todo Validate images from greyscale camera and force grescale mode
>          # \todo Debug functionality
>  

-- 
Regards,

Laurent Pinchart


More information about the libcamera-devel mailing list