[PATCH v2 25/25] libtuning: agc: rkisp1: Increase y-target

[Laurent Pinchart]

Hi Stefan,

Thank you for the patch.

On Fri, Jun 28, 2024 at 12:47:18PM +0200, Stefan Klug wrote:
> With the addition of gamma out correction the relative luminance target
> was set too low. As brightness is a bit subjective it is difficult to
> come up with the "correct" value. With 0.5 the patch 22 on the mac beth
> chart (neutral grey, 18% reflectance) ended up a bit below 50% grey,
> which seems reasonable.
> 
> Signed-off-by: Stefan Klug <stefan.klug at ideasonboard.com>

Let's start with that, we'll improve it later.

Reviewed-by: Laurent Pinchart <laurent.pinchart at ideasonboard.com>

> ---
>  utils/tuning/libtuning/modules/agc/rkisp1.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/utils/tuning/libtuning/modules/agc/rkisp1.py b/utils/tuning/libtuning/modules/agc/rkisp1.py
> index 19a5555b6111..7147028a774a 100644
> --- a/utils/tuning/libtuning/modules/agc/rkisp1.py
> +++ b/utils/tuning/libtuning/modules/agc/rkisp1.py
> @@ -64,7 +64,7 @@ class AGCRkISP1(AGC):
>          return {'ConstraintNormal': normal, 'ConstraintHighlight': highlight}
>  
>      def _generate_y_target(self) -> list:
> -        return 0.16
> +        return 0.5
>  
>      def process(self, config: dict, images: list, outputs: dict) -> dict:
>          output = {}

-- 
Regards,

Laurent Pinchart