[PATCH v3 3/9] libcamera: mali-c55: Init camera properties
Umang Jain
umang.jain at ideasonboard.com
Sat Jun 29 08:45:24 CEST 2024
Hi Dan and Jacopo,
On 26/06/24 7:32 pm, Jacopo Mondi wrote:
> From: Daniel Scally <dan.scally at ideasonboard.com>
>
> Initialise the camera properties using the CameraSensor properties.
>
> Signed-off-by: Daniel Scally <dan.scally at ideasonboard.com>
> Signed-off-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>
LGTM,
Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>
> ---
> src/libcamera/pipeline/mali-c55/mali-c55.cpp | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp
> index d1ae1a61d5a9..bffd842c2af1 100644
> --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp
> +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp
> @@ -965,7 +965,7 @@ bool PipelineHandlerMaliC55::registerSensorCamera(MediaLink *ispLink)
> if (data->init())
> return false;
>
> - /* \todo: Init properties and controls. */
> + data->properties_ = data->sensor_->properties();
>
> registerMaliCamera(std::move(data), sensor->name());
> }
More information about the libcamera-devel
mailing list