[PATCH v3 6/9] libcamera: mali-c55: Add stride and size to rawConfig

Umang Jain umang.jain at ideasonboard.com
Sat Jun 29 11:58:16 CEST 2024


Hi Jacopo, Dan

On 26/06/24 7:33 pm, Jacopo Mondi wrote:
> From: Daniel Scally <dan.scally at ideasonboard.com>
>
> Complete the RAW StreamConfiguration by populating the frame stride and
> the frame size.
>
> Set the minimum required alignment to 4 bytes as the Mali C55 ISP output
> expands RAW output to 16 bits and a RAW Bayer macro-pixel requires
> two samples to be complete.
>
> Signed-off-by: Daniel Scally <dan.scally at ideasonboard.com>
> Signed-off-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>
> Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

Reviewed-by: Umang Jain <umang.jain at ideasonboard.com>
> ---
>   src/libcamera/pipeline/mali-c55/mali-c55.cpp | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/src/libcamera/pipeline/mali-c55/mali-c55.cpp b/src/libcamera/pipeline/mali-c55/mali-c55.cpp
> index 877a156ccb84..28ad0172658c 100644
> --- a/src/libcamera/pipeline/mali-c55/mali-c55.cpp
> +++ b/src/libcamera/pipeline/mali-c55/mali-c55.cpp
> @@ -367,6 +367,10 @@ CameraConfiguration::Status MaliC55CameraConfiguration::validate()
>   
>   		maxSize = rawSize;
>   
> +		const PixelFormatInfo &info = PixelFormatInfo::info(rawConfig->pixelFormat);
> +		rawConfig->stride = info.stride(rawConfig->size.width, 0, 4);
> +		rawConfig->frameSize = info.frameSize(rawConfig->size, 4);
> +
>   		rawConfig->setStream(const_cast<Stream *>(&data_->frStream_));
>   		frPipeAvailable = false;
>   	}



More information about the libcamera-devel mailing list