[PATCH v4 08/18] libcamera: software_isp: Add DebayerCpu class

[Milan Zamazal]

Hans de Goede <hdegoede at redhat.com> writes:

> On 3/4/24 5:58 PM, Milan Zamazal wrote:

[...]
 
>> This patch is quite difficult to understand and I wonder what happens if this
>> piece of code needs to be modified a year or two later.  My primary problem with
>> it is tracking all the line pointers and where they point to at each given
>> moment.  I think more verbosity (code comments) is desirable unless other
>> reviewers think it's crystal clear.
>
> I tried to explain how this works already in the new comments in this
> v4 series. I think it might be best for someone less familiar with
> the code to add extra comments since to me the working is already clear.
>
> Maybe you can prepare a follow-up patch to add some extra comments
> in places where you believe that this is necessary ?

Hi Hans,

good idea, added to my TODO (this can be added anytime later, let's keep focus
on getting the branch merged for now).

Thank you for the expanded explanations of the vertical border handling, saving
them as a reference for the future comments.

Regards,
Milan