[PATCH] utils: checkstyle.py: Add Co-developed-by to known_trailers

Hans de Goede hdegoede at redhat.com
Mon Mar 11 13:54:58 CET 2024


Hi,

On 3/11/24 1:34 PM, Jacopo Mondi wrote:
> On Mon, Mar 11, 2024 at 01:01:02PM +0100, Hans de Goede wrote:
>> Add Co-developed-by to known_trailers to silence false positive
>> "Invalid commit trailer key 'Co-developed-by'" warnings.
>>
>> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
>> ---
>>  utils/checkstyle.py | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/utils/checkstyle.py b/utils/checkstyle.py
>> index fb03dc34..52cf770c 100755
>> --- a/utils/checkstyle.py
>> +++ b/utils/checkstyle.py
>> @@ -478,6 +478,7 @@ class TrailersChecker(CommitChecker):
>>          'Signed-off-by': email_regex,
>>          'Suggested-by': email_regex,
>>          'Tested-by': email_regex,
>> +        'Co-developed-by': email_regex,
> 
> Maybe keep this alphabetically sorted ?

Ah I did not realize this was alphabetically sorted.

I'll do a v2 keeping things sorted.

> 
> This apart
> Reviewed-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>

Thank you for the review.

Regards,

Hans





>>      }
>>
>>      trailer_regex = re.compile(r'([A-Z][a-zA-Z-]*)\s*:\s*(.*)')
>> --
>> 2.44.0
>>
> 



More information about the libcamera-devel mailing list