[PATCH v2 3/3] libcamera: framebuffer_allocator: Remove entry if allocation fails

[Kieran Bingham]

Quoting Barnabás Pőcze (2024-03-10 14:30:43)
> Remove the entry from the `buffers_` mapping if
> `Camera::exportFrameBuffers()` fails, otherwise
> there would be a stale entry in the map.
> 
> Signed-off-by: Barnabás Pőcze <pobrn at protonmail.com>
> ---
>  src/libcamera/framebuffer_allocator.cpp | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/src/libcamera/framebuffer_allocator.cpp b/src/libcamera/framebuffer_allocator.cpp
> index fc19a33a..dbd0db19 100644
> --- a/src/libcamera/framebuffer_allocator.cpp
> +++ b/src/libcamera/framebuffer_allocator.cpp
> @@ -97,6 +97,10 @@ int FrameBufferAllocator::allocate(Stream *stream)
>                 LOG(Allocator, Error)
>                         << "Stream is not part of " << camera_->id()
>                         << " active configuration";
> +
> +       if (ret < 0)
> +               buffers_.erase(it);
> +

Reviewed-by: Kieran Bingham <kieran.bingham at ideasonboard.com>

>         return ret;
>  }
>  
> -- 
> 2.44.0
> 
>