[PATCH v2 2/3] libcamera: framebuffer_allocator: Use default destructor

Jacopo Mondi jacopo.mondi at ideasonboard.com
Mon Mar 11 18:01:40 CET 2024


Hi Barnabás

On Sun, Mar 10, 2024 at 02:30:38PM +0000, Barnabás Pőcze wrote:
> The compiler generated destructor works fine, so use that.
>
> Signed-off-by: Barnabás Pőcze <pobrn at protonmail.com>

Reviewed-by: Jacopo Mondi <jacopo.mondi at ideasonboard.com>

> ---
>  src/libcamera/framebuffer_allocator.cpp | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/src/libcamera/framebuffer_allocator.cpp b/src/libcamera/framebuffer_allocator.cpp
> index 8cf45ab2..fc19a33a 100644
> --- a/src/libcamera/framebuffer_allocator.cpp
> +++ b/src/libcamera/framebuffer_allocator.cpp
> @@ -63,10 +63,7 @@ FrameBufferAllocator::FrameBufferAllocator(std::shared_ptr<Camera> camera)
>  {
>  }
>
> -FrameBufferAllocator::~FrameBufferAllocator()
> -{
> -	buffers_.clear();
> -}
> +FrameBufferAllocator::~FrameBufferAllocator() = default;
>
>  /**
>   * \brief Allocate buffers for a configured stream
> --
> 2.44.0
>
>


More information about the libcamera-devel mailing list