[PATCH 01/10] ipa: libipa: Allow creation of empty Histogram
Jacopo Mondi
jacopo.mondi at ideasonboard.com
Mon Mar 25 16:45:08 CET 2024
Hi Dan
On Fri, Mar 22, 2024 at 01:14:42PM +0000, Daniel Scally wrote:
> For convenience's sake allow the creation of empty Histograms so
> they can be embedded within other Classes and filled out with
> data at some later point in time.
>
How are you going to add data to the Histogram since they seem to be
expected to be passed in at construction time ?
> Signed-off-by: Daniel Scally <dan.scally at ideasonboard.com>
> ---
> src/ipa/libipa/histogram.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/src/ipa/libipa/histogram.h b/src/ipa/libipa/histogram.h
> index 05bb4b80..db13c155 100644
> --- a/src/ipa/libipa/histogram.h
> +++ b/src/ipa/libipa/histogram.h
> @@ -22,6 +22,7 @@ namespace ipa {
> class Histogram
> {
> public:
> + Histogram() { cumulative_.push_back(0); };
> Histogram(Span<const uint32_t> data);
> size_t bins() const { return cumulative_.size() - 1; }
> uint64_t total() const { return cumulative_[cumulative_.size() - 1]; }
> --
> 2.34.1
>
More information about the libcamera-devel
mailing list